Re: [clearview-discuss] libdlpi with libpcap

[Sebastien Roy <Sebastien.Roy () Sun COM>]

sagun shakya wrote:
> Sebastien Roy wrote:
> > sagun shakya wrote:
> > > > > pcap-int.h:
> > > > >
> > > > > * 71-98: These only apply when compiling with DLPI support.  
> > > > > Perhaps Guy can answer this:  Should there be some sort of #ifdef 
> > > > > to make sure that these symbols don't pollute the namespace when 
> > > > > compiled on other platforms?
> > > > >
> > > > > * 376-385: Same comment here.     
> > > > When compiling with libdlpi, a #ifdef HAVE_LIBDLPI can be done but 
> > > > for just dlpi, a HAVE_DLPI would need to be defined.  
> > > Another solution and probably a simpler one, is to just add a 
> > > dlpisubs.h header  file.
> > Yes, I think that would work just fine.
> I've updated the webrev and tested the changes on a system with and 
> without libdlpi.
>
> Updated webrev can be found at:
>
> http://cr.opensolaris.org/~sagun/libpcap-review2/

Looks good.
-Seb
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.