Re: [clearview-discuss] libdlpi with libpcap

[sagun shakya <Sagun.Shakya () Sun COM>]

Peter Memishian wrote:
>  > Due to other work priority I wasn't able to work on fixing and
>  > addressing these comments.  I have finally addressed the comments from
>  > Meem and made a few other changes. My comments are inline and please
>  > find an update webrev at:
>  > 
>  > http://cr.opensolaris.org/~sagun/libpcap/
>
> I see a number of changes that were apparently made to make Sun cstyle
> happy (e.g., comment changes).  These changes are inappropriate and need
> to be undone -- and a new webrev should be posted.
>   
I mostly fixed the comment changes, thinking they were trivial and left 
other Sun cstyle error alone. I can see how it is distracting while 
reviewing  the actual changes. I've undone such changes and posted a new 
webrev at:

http://cr.opensolaris.org/~sagun/libpcap/

If you'd like to see the changes made from the previous code review you 
can find a webrev at:

http://cr.opensolaris.org/~sagun/codereview_fix/


Sagun

-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.