Re: Last call for smtp-open-relay.nse - help needed

[Duarte Silva <duartejcsilva () gmail com>]

Hi,

I decided to retest the script and still got some exceptions and
errors. It seems I was able to fix it and currently the script looks
pretty stable.

Patch bellow, best regards,
Duarte

On Sat, Feb 20, 2010 at 9:30 PM, Duarte Silva <duartejcsilva () gmail com> wrote:
> Hi,
>
> I made all the changes that you and Fyodor recommended. I also have
> made some more improvements,
> Changed script output to show all the successful tests
> Changed from string concatenation to string formatting
> QUIT message before closing connection (as wrote in the SMTP rfc)
>
> Patch in the attachments, best regards,
> Duarte Silva
>
> On Thu, Feb 18, 2010 at 3:57 PM, Duarte Silva <duartejcsilva () gmail com> wrote:
> > Nice thanks. I will cook the fix and test it over the weekend.
> >
> > Best regards,
> > Duarte
> >
> > On Thu, Feb 18, 2010 at 3:35 PM, David Fifield <david () bamsoftware com> wrote:
> > > On Thu, Feb 18, 2010 at 01:36:43PM +0000, Duarte Silva wrote:
> > > > > Okay, here are a few things.
> > > > >
> > > > > > -- @args domain Define the domain to be used in the anti-spam tests (default is nmap.scanme.org)
> > > > > > -- @args ip Use this to change the IP address to be used (default is the target IP address)
> > > >
> > > > So something like nmap.registry.args.domain will become
> > > > nmap.registry.args.smtp-open-relay.domain right?
> > >
> > > Yes, except you have to write it as
> > > nmap.registry.args["smtp-open-relay.domain"].
> > >
> > > > > NSE: smtp-open-relay against 69.164.193.231:25 threw an error!
> > > > > EOF
> > > > > stack traceback:
> > > > >        [C]: in function 'try'
> > > > >        ./scripts/smtp-open-relay.nse:67: in function 'dorequest'
> > > > >        ./scripts/smtp-open-relay.nse:148: in function 'go'
> > > > >        ./scripts/smtp-open-relay.nse:206: in function <./scripts/smtp-open-relay.nse:205>
> > > > >        (tail call): ?
> > > >
> > > > Ok, will take a look at it.
> > >
> > > The problem isn't the handling of the 501 error; I think that's already
> > > correct. The problem is the handling of the EOF. The script just needs
> > > to check for EOF and exit gracefully.
> > >
> > > David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/