Wireshark mailing list archives
Re: Adding a new dissector - beginners guide
From: Michal Orynicz <michal.orynicz () tieto com>
Date: Thu, 21 Aug 2014 14:49:24 +0200
... or do it with ssh protocol, just as You described it. On 21 August 2014 14:46, Michal Orynicz <michal.orynicz () tieto com> wrote:
Hi, the best line of doing this would be going to https://code.wireshark.org/review/, registering there and then pushing Your change to https://code.wireshark.org/review/wireshark . This way the changes will go through review in gerrit, and no matter how bad or how good Your code is, it will stay there until it is decided to be ready and safe to be incorporated to the main branch :) On 21 August 2014 14:39, Thomas Wiens <th.wiens () gmx de> wrote:Hi, I have written a dissector for a protocol which I call "S7 communication". I've hosted it as plugin dll at sourceforge, but I think the better way is to contribute it direct into wireshark (if it's good enough). I've changed the dissector from plugin to internal and did the testtools, so I think I am ready to go. The main problem is that I'm new to git/gerrit. I don't want to destroy or confuse anything in your code repository, and the wireshark docs don't write it step by step how to do it. I would like to write down what I want to do, and I hope that someone corrects me when I am wrong. What I have done: - created a local copy via git clone https://code.wireshark.org/review/wireshark - I've added four files into epan/dissectors: packet-s7comm.c packet-s7comm_szl_ids.c packet-s7comm.h packet-s7comm_szl_ids.h - I've changed two files: epan/CMakeLists.txt epan/dissectors/Makefile.common config.nmake And the steps to push the files up (haven't done it yet): git add epan/dissectors/packet-s7comm.c git add epan/dissectors/packet-s7comm_szl_ids.c git add epan/dissectors/packet-s7comm.h git add epan/dissectors/packet-s7comm_szl_ids.h git add epan/CMakeLists.txt git add epan/dissectors/Makefile.common git commit -m "Add S7COMM protocol" -m "Dissector T.125 has to be disabled to let this dissector work." and finally: git push ssh://thomas_v2 () code wireshark org:29418/wireshark HEAD:refs/for/master/s7comm I don't know how to fix the problem with the concurrent T.125 dissector, seems that my captures are also valid T.125 protocols. Thanks, Thomas Wiens ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org ?subject=unsubscribe-- Pozdrawiam / Best regards Michał Orynicz, Software Engineer Tieto Corporation Product Development Services http://www.tieto.com / http://www.tieto.pl --- ASCII: Michal Orynicz location: Swobodna 1 Street, 50-088 Wrocław, Poland room: 5.01 (desk next to 5.08) --- Please note: The information contained in this message may be legally privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient, you are hereby notified that any unauthorised use, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to the message and deleting it from your computer. Thank You. --- Please consider the environment before printing this e-mail. --- Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego Rejestru Sądowego pod numerem 0000124858. NIP: 8542085557. REGON: 812023656. Kapitał zakładowy: 4 271500 PLN
-- Pozdrawiam / Best regards Michał Orynicz, Software Engineer Tieto Corporation Product Development Services http://www.tieto.com / http://www.tieto.pl --- ASCII: Michal Orynicz location: Swobodna 1 Street, 50-088 Wrocław, Poland room: 5.01 (desk next to 5.08) --- Please note: The information contained in this message may be legally privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient, you are hereby notified that any unauthorised use, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to the message and deleting it from your computer. Thank You. --- Please consider the environment before printing this e-mail. --- Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego Rejestru Sądowego pod numerem 0000124858. NIP: 8542085557. REGON: 812023656. Kapitał zakładowy: 4 271500 PLN
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Adding a new dissector - beginners guide Thomas Wiens (Aug 21)
- Re: Adding a new dissector - beginners guide Michal Orynicz (Aug 21)
- Re: Adding a new dissector - beginners guide Michal Orynicz (Aug 21)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 21)
- Re: Adding a new dissector - beginners guide Graham Bloice (Aug 21)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 21)
- Re: Adding a new dissector - beginners guide Graham Bloice (Aug 21)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 21)
- Re: Adding a new dissector - beginners guide Jeff Morriss (Aug 21)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 21)
- Re: Adding a new dissector - beginners guide Jeff Morriss (Aug 21)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 21)
- Re: Adding a new dissector - beginners guide Martin Kaiser (Aug 21)
- Re: Adding a new dissector - beginners guide Michal Orynicz (Aug 21)