Wireshark mailing list archives
Re: r43579 "Generic preference implementation" broken compile
From: mmann78 () netscape net
Date: Fri, 6 Jul 2012 14:43:49 -0400 (EDT)
Yes, the following files can now be deleted: \wireshark\ui\gtk\prefs_nameres.c \wireshark\ui\gtk\prefs_nameres.h \wireshark\ui\gtk\prefs_print.c \wireshark\ui\gtk\prefs_print.h \wireshark\ui\gtk\prefs_protocols.c \wireshark\ui\gtk\prefs_protocols.h \wireshark\ui\gtk\prefs_taps.c \wireshark\ui\gtk\prefs_taps.h I thought removing them was part of the patch for bug 7402, but they still show up in the SVN (perhaps I didn't create the patch correctly). Hopefully no one has started porting them to qt. -----Original Message----- From: Stephen Fisher <steve () stephen-fisher com> To: Developer support list for Wireshark <wireshark-dev () wireshark org> Sent: Fri, Jul 6, 2012 2:24 pm Subject: Re: [Wireshark-dev] r43579 "Generic preference implementation" broken compile ---- On Fri, 06 Jul 2012 12:03:30 -0600 <mmann78 () netscape net> wrote ----
Also, prefs_nameres.c shouldn't be building anymore. The top of the tree
should have it removed from any makefiles (unless I screwed up the patch). The functionality of prefs_nameres.c was replaced with the generic handling of preferences that used to be unique to only protocol preferences.
A "make clean" didn't resolve the issue, but a fresh checkout did allow it to compile. If we're not using prefs_nameres.c anymore, can we delete it? ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- r43579 "Generic preference implementation" broken compile Stephen Fisher (Jul 06)
- Re: r43579 "Generic preference implementation" broken compile Pascal Quantin (Jul 06)
- Re: r43579 "Generic preference implementation" broken compile Stephen Fisher (Jul 06)
- Re: r43579 "Generic preference implementation" broken compile mmann78 (Jul 06)
- Re: r43579 "Generic preference implementation" broken compile Stephen Fisher (Jul 06)
- Re: r43579 "Generic preference implementation" broken compile mmann78 (Jul 06)
- Re: r43579 "Generic preference implementation" broken compile Guy Harris (Jul 06)
- Re: r43579 "Generic preference implementation" broken compile Guy Harris (Jul 06)
- Re: r43579 "Generic preference implementation" broken compile Guy Harris (Jul 06)
- Re: r43579 "Generic preference implementation" broken compile Anders Broman (Jul 06)
- Re: r43579 "Generic preference implementation" broken compile Pascal Quantin (Jul 06)