Wireshark mailing list archives

Re: Still compile problems with capture_dlg.c


From: Michael Tuexen <Michael.Tuexen () lurchi franken de>
Date: Sat, 6 Aug 2011 22:14:56 +0200

On Aug 6, 2011, at 9:48 PM, Joerg Mayer wrote:

Hello Michael,

On Sat, Aug 06, 2011 at 07:39:57PM +0200, Michael Tuexen wrote:
from what I could see is that the functions (I #if 0 out) are never called.
I just wanted to keep the code if it turns out that it is needed when
Irene is working on implementing the suggestions.
I've put an item on our ToDo list to finally cleanup the source code.
I'm wondering why our compilers did not complain...

You probably didn't have PCAP_REMOTE set - on libpcap systems that is a
rare thing.
Sure. But the functions you listed were not called at all, no
matter #ifdef you have.. For example iftype_combo_box_new()...
Or I'm missing something...

Best regards
Michael

Ciao
     Joerg
-- 
Joerg Mayer                                           <jmayer () loplof de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: