Re: HAVE_PCAP symbols by build type

[Joerg Mayer <jmayer () loplof de>]

Hello Guy,

On Sat, Aug 06, 2011 at 02:37:48AM -0700, Guy Harris wrote:
> The only calls to pcap_findalldevs_ex() are protected by HAVE_PCAP_REMOTE.  This may have to be redone when remote 
> capture support is added to libpcap.

Yes, and that's why it is set on my system, I just didn't add it to
cmakeconfig.h.in

> HAVE_PCAP_OPEN is equivalent to "have WinPcap" which is equivalent to "is running on Windows".  The same is true of 
> HAVE_PCAP_SETSAMPLING.

HAVE_PCAP_OPEN also exists on my system, due to the pcap-remote patches.
Again it was not added to cmakeconfig.h.in

I will do this on my system now and see what breaks:

dumpcap.c:
/home/jmayer/work/wireshark/svn/trunk/dumpcap.c: In function ‘get_if_capabilities’:
/home/jmayer/work/wireshark/svn/trunk/dumpcap.c:1015:9: error: unused variable ‘status’
/home/jmayer/work/wireshark/svn/trunk/dumpcap.c:1005:51: error: unused parameter ‘monitor_mode’

I've attached the patch that was used to create the problem ;-)
As I really don't know whether it makes sense to set all these variables I'd like
to leave this to you - btw, do you have a time plan for rpcap support in the
official libpcap sources?

Thanks!
    Joerg
-- 
Joerg Mayer                                           <jmayer () loplof de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.

Attachment: pcap-vars-complete.patch
Description:

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe