Wireshark mailing list archives

Re: Familiar with gtk/sctp_graph_dlg.c?


From: Michael Tüxen <Michael.Tuexen () lurchi franken de>
Date: Tue, 26 Apr 2011 20:35:30 +0200

On Apr 26, 2011, at 7:03 PM, Guy Harris wrote:


On Apr 26, 2011, at 1:12 AM, Michael Tüxen wrote:

The fields in the packet are 4 byte aligned. But if the whole structure might not...
So should we copy them?

...or fetch them with pntohl().

Where are the contents of the structure coming from?  If they're coming from the raw packet data - i.e., if the 
pointer in question is pointing into the raw packet data from the tvbuff handed to the SCTP dissector - then not only 
might the data not be aligned on a 4-byte boundary, it might not even contain all the data you're looking at if the 
packet was cut short by a snapshot length.
I'll let Irene (who wrote the code) look into this. However, she is currently
on vacation. So it might take some time...

Best regards
Michael
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: