Re: Familiar with gtk/sctp_graph_dlg.c?

[Michael Tüxen <Michael.Tuexen () lurchi franken de>]

On Apr 25, 2011, at 11:50 PM, Chris Maynard wrote:

> Stephen Fisher <steve@...> writes:
>
> > Anyone familiar with gtk/sctp_graph_dlg.c?  This line in particular 
> > (#270):
> >
> > dup_list = (guint32 *)(((char
> *)&sack_header->nr_of_dups)+sizeof(guint16)+(nr*sizeof(struct 
> > gaps)));
> >
> > I'm trying to investigate a clang error about this increasing required 
> > alignment from 1 to 4 and the complexity of that line is making my brain 
> > hurt :)
>
> Ouch!  I haven't spent a ton of time looking at this, but I don't understand it
> either.  Maybe the authors - Irene and/or Varun - could be of help?
>
> By the way, while looking around a bit, I think I found a memory leak at line 
> 1555:
>
> 1555: u_data->assoc=g_malloc(sizeof(sctp_assoc_info_t));
> 1556: u_data->assoc=userdata->assoc;
>
> I assume line 1555 should be deleted?
Sounds good...

Best regards
Michael
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe