Wireshark mailing list archives
Re: Familiar with gtk/sctp_graph_dlg.c?
From: Michael Tüxen <Michael.Tuexen () lurchi franken de>
Date: Tue, 26 Apr 2011 00:01:59 +0200
On Apr 25, 2011, at 11:02 PM, Stephen Fisher wrote:
Anyone familiar with gtk/sctp_graph_dlg.c? This line in particular (#270): dup_list = (guint32 *)(((char *)&sack_header->nr_of_dups)+sizeof(guint16)+(nr*sizeof(struct gaps)));
It computes the the pointer to the list of duplicates based on the pointer the number of duplicates. The packet format is: 0 1 2 3 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Type = 3 |Chunk Flags | Chunk Length | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Cumulative TSN Ack | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Advertised Receiver Window Credit (a_rwnd) | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Number of Gap Ack Blocks = N | Number of Duplicate TSNs = X | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Gap Ack Block #1 Start | Gap Ack Block #1 End | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ / / \ ... \ / / +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Gap Ack Block #N Start | Gap Ack Block #N End | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Duplicate TSN 1 | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ / / \ ... \ / / +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Duplicate TSN X | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ So the sizeof(guint16) accounts for the length of the Number of Duplicate TSNs fields, and the nr*sizeof(struct gaps) for the list of pairs of Gap Ack Block start and end. This line looks OK to me... Maybe clang likes something like: dup_list = (guint32 *)((char *)sack_header + 16 + (nr * sizeof(struct gaps))) Best regards Michael
I'm trying to investigate a clang error about this increasing required alignment from 1 to 4 and the complexity of that line is making my brain hurt :) ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Familiar with gtk/sctp_graph_dlg.c? Stephen Fisher (Apr 25)
- Re: [Wireshark-dev] Familiar with gtk/sctp_graph_dlg.c? Chris Maynard (Apr 25)
- Re: Familiar with gtk/sctp_graph_dlg.c? Michael Tüxen (Apr 25)
- Re: Familiar with gtk/sctp_graph_dlg.c? Michael Tüxen (Apr 25)
- Re: Familiar with gtk/sctp_graph_dlg.c? Guy Harris (Apr 25)
- Re: Familiar with gtk/sctp_graph_dlg.c? Michael Tüxen (Apr 26)
- Re: [Wireshark-dev] Familiar with gtk/sctp_graph_dlg.c? Christopher Maynard (Apr 26)
- Re: Familiar with gtk/sctp_graph_dlg.c? Guy Harris (Apr 26)
- Re: Familiar with gtk/sctp_graph_dlg.c? Michael Tüxen (Apr 26)
- Re: Familiar with gtk/sctp_graph_dlg.c? Guy Harris (Apr 25)
- Re: [Wireshark-dev] Familiar with gtk/sctp_graph_dlg.c? Chris Maynard (Apr 25)
- Re: Familiar with gtk/sctp_graph_dlg.c? Michael Tüxen (Apr 26)
- Re: [Wireshark-dev] Familiar with gtk/sctp_graph_dlg.c? Chris Maynard (Apr 26)
- Re: [Wireshark-dev] Familiar with gtk/sctp_graph_dlg.c? Chris Maynard (Apr 26)