Wireshark mailing list archives

RFC: sorted value_string + bsearch


From: Jakub Zawadzki <darkjames () darkjames ath cx>
Date: Mon, 12 Apr 2010 02:28:22 +0200

Hi,

In wireshark there are some large value_string arrays.
Some developers keep them sorted, some don't :)

Dissectors in which value_string are sorted could be a little faster
thanks to binary search.

In attachment patch to introduce new 'fast' functions for value_string.

Can this patch be commited? I don't know if I will have time to rewrite dissectors.
Some time later it should be also possible to get rid of (hated) value_string NULL terminator. 


I'm also attaching sample dns_types rewrite.

Cheers.

Attachment: strval-bsearch.patch
Description:

Attachment: foo.patch
Description:

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: