Re: Four more warning fix patches

[Guy Harris <guy () alum mit edu>]

On Mar 28, 2018, at 2:46 PM, Joerg Mayer <jmayer () loplof de> wrote:

> These patches turn on some more warnings (or not) and fixes all warnings that come up
>
> Notes:
> - 0001 is not sent (it's the previously sent -Wshadow fix)

Turning that rock over found a lot more underneath; the whole way rpcapd manages worker threads/processes really should 
be cleaned up.  I'm looking at that.

> Please apply in case they make sense.

Checked in, with some fixes to the Windows builds, and with the new -W flags added to aclocal.m4 as well, so they're 
enabled in both autotools and CMake.

Thanks.

BTW, if you submit them via GitHub as pull requests, GitHub will trigger "Petri dish" build on both Travis (Linux, 
macOS) and AppVeyor (Windows).  Right now, Travis is a bit backed up due to some issues with the site that's providing 
macOS buildbots, but it's normally fairly quick (or as quick as it can be, given that it does 16 builds, from {GCC, 
Clang} x {Linux, macOS} x {autotools, CMake} x {no-remote, remote}).
_______________________________________________
tcpdump-workers mailing list
tcpdump-workers () lists tcpdump org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers