Re: pcap-bpf and AIX odm related code

[Jean-Louis Charton <jean-louis.charton () oikialog com>]

Hi Guy,


> I've checked in and pushed your changes on the main Git branch.

Thank you for commiting the fix I suggested.

However, I've got a little comment:
in my fix proposal, in bpf_load() function Ipassed a dummy_err buffer instead of
errbuf to the 2 bpf_odmcleanup() calls.
This was intentional to avoid squashing errbuf if for some reason bpf_odmcleanup
also fails.
I wrote it that way because to my point of vue, errbuf is supposed to be set to
the first encountered error not a potential error in some cleanup code.

Jean-Louis.


-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.