Re: [Patch] Send comment in scan packet data

[Daniel Miller <bonsaiviking () gmail com>]

> From a design standpoint, I have a couple comments:

1. Using "--comment" seems like a limitation of this feature. Compare
Nping's options:

  --data <hex string>              : Include a custom payload.
  --data-string <text>             : Include a custom ASCII text.
  --data-length <len>              : Include len random bytes as payload.

The --data-length option is the same. Is there any reason why Nmap can't
also support --data-string and --data? (Though I would prefer --data-hex,
it might be nice to keep the same syntax.)

2. As a follow-up to this feature being added, we should probably do some
testing with IPv6, especially given the warning about data length > 1400
which is based on IPv4. This may require some coding to add support for
Jumbograms.

Dan


On Thu, May 8, 2014 at 6:10 AM, Jay Bosamiya <jaybosamiya () gmail com> wrote:

> Looked through it right now. And, yeah, the error is in fact required.
> I rewrote my patch to include the error.
>
> I can think of no reason to not add the --comment option at that time
> other than the fact that nmap was in feature freeze (as you mentioned).
> I've tested it and it doesn't seem to be causing any problems whatsoever.
> However, I think only Fyodor will be able to tell the reason now. That's
> why I cc'd this mail.
>
> Attached: The new patch.
>
> Cheers,
> Jay Bosamiya
>
>
> On Wednesday 07 May 2014 09:43 PM, Kris Katterjohn wrote:
>
> > Here is my patch from long ago:http://seclists.org/nmap-dev/2007/q3/423
> >
> > It gives an error when using --data-length and --comment together.
> >
> > I recall talking to Fyodor about the patch after I posted it and there
> > was some reason he didn't want it added at the time.
> >
> > Cheers,
> > Kris Katterjohn
>
>
> _______________________________________________
> Sent through the dev mailing list
> http://nmap.org/mailman/listinfo/dev
> Archived at http://seclists.org/nmap-dev/
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/