Re: [Patch] Send comment in scan packet data

[Jay Bosamiya <jaybosamiya () gmail com>]

Looked through it right now. And, yeah, the error is in fact required.
I rewrote my patch to include the error.

I can think of no reason to not add the --comment option at that time 
other than the fact that nmap was in feature freeze (as you mentioned).
I've tested it and it doesn't seem to be causing any problems whatsoever.
However, I think only Fyodor will be able to tell the reason now. That's 
why I cc'd this mail.

Attached: The new patch.

Cheers,
Jay Bosamiya

On Wednesday 07 May 2014 09:43 PM, Kris Katterjohn wrote:
> Here is my patch from long ago:http://seclists.org/nmap-dev/2007/q3/423
>
> It gives an error when using --data-length and --comment together.
>
> I recall talking to Fyodor about the patch after I posted it and there
> was some reason he didn't want it added at the time.
>
> Cheers,
> Kris Katterjohn

Attachment: patch.patch
Description:

_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/