RE: [nmap-svn] r26092 - nmap/todo

["Rob Nicholls" <robert () robnicholls co uk>]

My bad, I think. I believe I've found the issue (essentially a copy and
paste error on my part), briefly tested it and just committed a fix
(r26106).

Some code nearer the top specifically checked that our "InstalledBy"
registry key was present so we knew we could silently uninstall WinPcap with
our uninstaller, rather than reading the "UninstallString" like we do later
on in the code for a non-silent installation when we don't care whose
version of the uninstaller is executed. I added a line to read the value of
"UninstallString" rather than use the "InstalledBy" string just before we
silently execute our uninstaller. Basically, the old code meant that the
ExecWait command was running 'Nmap /S _?=$INSTDIR' which is why Nmap would
run rather than the uninstaller.

Not sure how I missed this during testing to be honest, I was probably too
busy creating blank and legacy registry keys to check what happened if we
silently ran our installer twice.

Fyodor, hope you didn't mind me removing the item from the Nmap todo file at
the same time as committing the fix.

Rob

-----Original Message-----
From: nmap-svn-bounces () insecure org [mailto:nmap-svn-bounces () insecure org]
On Behalf Of commit-mailer () insecure org
Sent: 20 August 2011 08:38
To: nmap-svn () insecure org
Subject: [nmap-svn] r26092 - nmap/todo

Author: fyodor
Date: Sat Aug 20 00:37:37 2011
New Revision: 26092

Log:
Note a minor problem with Winpcap installer

Modified:
   nmap/todo/nmap.txt

Modified: nmap/todo/nmap.txt
============================================================================
==
--- nmap/todo/nmap.txt  (original)
+++ nmap/todo/nmap.txt  Sat Aug 20 00:37:37 2011
@@ -27,6 +27,15 @@
   Matthew Stickey and Joe McEachern of QA Cafe.  See this thread:
   http://seclists.org/nmap-dev/2011/q3/227
 
+o When our winpcap installer is run in silent mode
+  (e.g. "winpcap-nmap-4.12.exe /S"), it seems to execute nmap.exe if
+  that binary exists in the same directory.  This leads to a cmd.exe
+  window briefly poping up as Nmap displays its console help output.
+  Moving the Winpcap installer into its own subdir and running it from
+  there seems to fix this (because it then can't find nmap.exe to
+  run), but it would be better to determine why this is happening in
+  the first place and fix it.
+
 ==Things needed for next STABLE release go ABOVE THIS LINE==
 
 o We should document Ron's sample script

_______________________________________________
Sent through the nmap-svn mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-svn


_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/