Re: [NSE] http.lua cleanups

[David Fifield <david () bamsoftware com>]

On Wed, Oct 27, 2010 at 11:03:01PM -0500, Ron wrote:
> I've spent the past few days cleaning up http.lua functions, and I'm pretty happy with the result I have now. Among 
> other things, I:
> o Updated the documentation on pretty much every function
> o Updated the module documentation to discuss how to use http.lua, along with an example
> o Changed the interface to http.pipeline to work be significantly cleaner, and documented it
>   (I also kept the old interface, which prints a warning and calls the new function)
> o Made functions 'local' that should have been, and that aren't being used
> o Document and validate the 'options' table
> o Document the 'response' table
> o Change nmap.registry.args.* to stdnse.get_script_args()
> o Normalized indentation and style, where possible, including function definitions ('function xxx()' instead of 'xxx 
> = function()'). 

This looks good. You can commit it.

In general, if you're making style changes only, and people aren't
likely to object to the style changes, you can just commit them without
asking. I appreciate you keeping backwards-compatible pipeline
functions.

Do you have a way to test (i.e., render) NSEDoc markup? I've been
thinking we should make that easier for script authors.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/