Nmap Development mailing list archives

[NSE] http.lua cleanups


From: Ron <ron () skullsecurity net>
Date: Wed, 27 Oct 2010 23:03:01 -0500

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey,

I've spent the past few days cleaning up http.lua functions, and I'm pretty happy with the result I have now. Among 
other things, I:
o Updated the documentation on pretty much every function
o Updated the module documentation to discuss how to use http.lua, along with an example
o Changed the interface to http.pipeline to work be significantly cleaner, and documented it
  (I also kept the old interface, which prints a warning and calls the new function)
o Made functions 'local' that should have been, and that aren't being used
o Document and validate the 'options' table
o Document the 'response' table
o Change nmap.registry.args.* to stdnse.get_script_args()
o Normalized indentation and style, where possible, including function definitions ('function xxx()' instead of 'xxx = 
function()'). 

The code is in svn://svn.insecure.org/nmap-exp/ron/nmap-http-cleanup and I'm also attaching a .patch. 

I realize I've changed code written by a lot of different people, often only for reasons of style, so I apologize now 
if I offended anybody by changing their code. 

I'd like to do this, to some extent or other, to all of our libraries. I enjoy cleaning and documenting, and having 
better documentation will do wonders to help new script writers get going. 

Comments are always welcome! 

Ron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)

iEYEARECAAYFAkzI9f4ACgkQ2t2zxlt4g/SdNgCfROUzj7IhMuW3yLE9PjWM8KOo
1i0An3171f/YG6XoTWdjUZkY34+FO8sy
=SK2J
-----END PGP SIGNATURE-----

Attachment: http-cleanup-1.diff
Description:

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/

Current thread: