Re: Nping build breakage on opensolaris

[David Fifield <david () bamsoftware com>]

On Tue, Mar 23, 2010 at 11:44:17PM -0700, Fyodor wrote:
> On Fri, Mar 12, 2010 at 08:43:37PM -0500, jrf wrote:
> > All,
> >
> > Given recent news, I don't know how relevant this will be, but I tried
> > doing a self hosted build of nmap on the following platform:
> >
> >  SunOS opensolaris 5.11 snv_111b i86pc i386 i86pc Solaris
> [...]
> > g++ -c -I../libdnet-stripped/include  -I../nbase -I../nsock/include -g
> > -O2 -Wall  -fno-strict-aliasing   -DHAVE_CONFIG_H
> > -DNPING_NAME=\"Nping\" -DNPING_URL=\"http://nmap.org/nping\";
> > -DNPING_PLATFORM=\"i386-pc-solaris2.11\"
> > -DNPINGDATADIR=\"/usr/local/share/nping\" -D_FORTIFY_SOURCE=2
> > ArgParser.cc -o ArgParser.o
> > In file included from common_modified.h:101,
> >                  from NpingTargets.h:100,
> >                  from NpingOps.h:150,
> >                  from ArgParser.cc:101:
> > common.h:133: error: `u_int8_t' does not name a type
> > common.h:134: error: `u_int8_t' does not name a type
>
> For what it is worth, I get the same errors on my Solaris 9 SPARC box:
>
> SunOS hostname 5.9 Generic_117171-07 sun4u sparc SUNW,Ultra-5_10
>
> As David noted, Nmap's tcpip.h has similar code without this issue.  I
> think Nping really needs to share code better with Nmap rather than
> cutting and pasting so much.  In many cases, I think the code needs to
> be taken out of Nmap and Nping then placed in Nbase (or perhaps other
> places) so it can be shared.
>
> I fixed a bunch of Nmap Solaris issues tonight, and this is the last
> issue preventing "./configure;make" from working.  But I don't have
> any more time tonight, so I had to ./configure --without-nping for
> now.  Anyone else who wants to give it a shot is welcome to.

I made nping/common.h include <sys/types.h>. I can't test that for
Solaris, but I'm pretty sure it will solve the problem. Does it work for
you, Jay or Fyodor?

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/