Re: [PATCH] --log-comment for, um, log comments

[David Fifield <david () bamsoftware com>]

On Sat, Aug 15, 2009 at 05:02:20AM -0500, Kris Katterjohn wrote:
> On 08/15/2009 01:54 AM, Fyodor wrote:
> > On Fri, Aug 14, 2009 at 11:28:55AM -0500, Kris Katterjohn wrote:
> > > I've attached a really simple patch I've just drawn up to add
> > > comments to the log output.
> >
> > Thanks Kris.  I like the idea, but I'd suggest including the comment
> > in an XML tag/attribute for XML output rather than an unidentified
> > comment.  After all, tools such as Zenmap and the XSLT we have for XML
> > to HTML translation might want to display the comment.  And that would
> > be a lot easier if it was an official tag and included in the DTD.
> > The DTD version number would have to increase too.
>
> Well as I mentioned in my previous email, I wanted the comment for all output
> formats and I don't personally see much value in the comment being able to be
> parsed out like in the XML.  However if having the comment as an XML attribute
> or whathaveyou would indeed be useful, then I'm all for it.  I'll most likely
> have a change of heart regarding the personal usefulness of it once it's
> implemented :)

There is already a comment element in the DTD for host comments. It
contains only freeform CDATA. (It's what gets set when you enter a
comment in the "Host Details" tab in Zenmap.) It could be reused as a
child of nmaprun in XML output without much trouble.

> Any thoughts on the comment in normal/grepable formats?

For normal output I liked the # example you gave.

David Fifield

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org