Re: [PATCH] --log-comment for, um, log comments

[Kris Katterjohn <katterjohn () gmail com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/15/2009 01:54 AM, Fyodor wrote:
> On Fri, Aug 14, 2009 at 11:28:55AM -0500, Kris Katterjohn wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Hey everybody,
> >
> > I've attached a really simple patch I've just drawn up to add comments to the
> > log output.
>
> Thanks Kris.  I like the idea, but I'd suggest including the comment
> in an XML tag/attribute for XML output rather than an unidentified
> comment.  After all, tools such as Zenmap and the XSLT we have for XML
> to HTML translation might want to display the comment.  And that would
> be a lot easier if it was an official tag and included in the DTD.
> The DTD version number would have to increase too.

Well as I mentioned in my previous email, I wanted the comment for all output
formats and I don't personally see much value in the comment being able to be
parsed out like in the XML.  However if having the comment as an XML attribute
or whathaveyou would indeed be useful, then I'm all for it.  I'll most likely
have a change of heart regarding the personal usefulness of it once it's
implemented :)

So I'll play around with it.

Any thoughts on the comment in normal/grepable formats?

> Cheers,
> -F

Thanks,
Kris Katterjohn

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQIcBAEBAgAGBQJKhoerAAoJEEQxgFs5kUfuvJwQAKn9e5tA1cjEXykecDU7j7fU
a7XtruEif0uSC6P/cqBlEyyRVhFqdFPBAuKlyNZoBJbMVnTII6YpErpCnFgJwNYq
XeJNc5361cFPYRKT686DnVJIyl+5jNcK0l7ZG9DIx0GDDmSVhNEx8Yrdwu2t4f0m
z7cVDw0kwYrqD8Qk6/pYiA3xZ3c7rKCeK9MFlZ+Yk1YutBPVFL+9K+L2XQGuSxH0
BB9LWlclzRuLBZU0b/idxCMlQc9qgaWZNoCai67oXPxiQMpaXHpitwgz2oTpEJuF
ICzm+HNf6PydvSYr4/jZZdfDe1qPAp98A9a9FUOGihiduSAmuVaW/ahc2rnBPuSc
fWM6ZyHQaFOVp7vzPEsGx1OIopyGKXCQKQsa3F+nNomlds/X0UhlNCzoi7GEqJ0t
vtxp4nIM91wE7p6bdcwID6zKLfn+FyYbc0m6+gjfI/dP0J6vdkrEzEKNI+eI+pDI
8EhuoHyGblcrmLobq4ZJFhaUm8wnqPaapa0X7EZp1dsB6Oe34FppqQQnPrGskU9a
6hN8ypIqCSX//7m47GfK4nQqqpgohjsAOV+FOPQe83gzaeqffuRvHRDH0VNTJYJa
V+DtCc9qyZX4J20bq7SfiRWt4ACEs8ODejckTMNfzsW96QMdL5ON6t9y7IKsKzxz
vUYI205PvrqCikekCJHZ
=RLxn
-----END PGP SIGNATURE-----

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org