Status report #4 of 17

[Patrick Donnelly <batrick () batbytes com>]

Accomplishments:
o Removed some unused locals in nse_main.lua

o Fixed a bug causing NSE to report that a --script expression did not
match files when it did. This happens when an expression matches a set
of scripts that were loaded by other expressions first. A simple
example is the same expression with different capitalization
(considered to be two different expressions).

o A warning is printed when a script in the script database cannot be
located using nmap_fetchfile. Nmap no longer exits due to this error.

o Upon connection failure, a socket will now unlock its "socket lock"
allowing other pending socket connections to succeed sooner. This
change only slightly speeds up the process as these sockets will be
collected eventually, causing the slots to be unlocked.

o Cleaned up the whitespace in nse_nsock.cc as per David's suggestion.
The whitespace was various styles in often confusing places. The
whitespace also had many evil tabs. I used the GNU indent program and
tried to follow the whitespace of the rest of NSE C code as closely as
possible.

o Corrected a bug in nse_nsock.cc that could result in the use of an
invalid Lua state if the thread was collected due to timeout or other
even more rare reasons. Essentially, the callbacks from the nsock
library were using a collected Lua state. I have solved this by
maintaining a reference to the Lua State Thread in the nsock
userdata's environment table.
This is a temporary patch for the stable release pending a more
detailed review of the NSE nsock library binding. See Brandon's report
at [1].


Priorities:
o Update NSE Book Implementation Section to reflect the new Lua based
Implementation.
o Continue discussion/work on --script-args with David.
o Implement a system to assist in resolving deadlocks by releasing
mutexes on thread death. Also update book concerning this.
o Other tasks in TODO when time permits.

-- 
-Patrick Donnelly

"Let all men know thee, but no man know thee thoroughly: Men freely
ford that see the shallows."

- Benjamin Franklin

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org