Re: [NSE patch] patch for pack/unpack to use platform independant types

[Fyodor <fyodor () insecure org>]

On Sat, Aug 16, 2008 at 06:02:35AM +0200, Philip Pickering wrote:
> +
> +#ifndef HAVE_INT32_T
> +#define HAVE_INT32_T
> +typedef signed long int32_t;
> +#endif
> +
> +
> +#ifndef HAVE_INT64_T
> +#define HAVE_INT64_T
> +typedef signed long long int64_t;
> +// typedef __int64 int64_t; // use instead?
> +#endif

Have you researched whether "signed long" is 32 bits on all Windows
platforms (including 64-bit platforms) and that "signed long long" is
always 64 bits?  Have you researched whether Windows provides type
definitions with a more explicit bitwidth guarantee?

Cheers,
-F

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org