RE: [NSE] NSE HTTP library

["Thomas Buchanan" <TBuchanan () thecompassgrp net>]

> I've tested the updated library and patch, and they seem to work as
> expected.  I've also ported my UPnP-info script over to your library,
> and it seems to work fine, but I want to do a little more 
> testing before I post the patch.

So, here is the patch for UPnP-info.nse to use the http library instead
of it's own HTTP connection calls.  It really simplifies things:

$ diffstat UPnP-info.patch
 UPnP-info.nse  1 file changed, 27 insertions(+), 60 deletions(-)

I had a couple of other observations while I was testing this patch:

1.  It might be helpful to check the status and error codes from the
socket:connect() and socket:send() calls in http:request().  If we get
an error from either call, I don't think it should try and continue to
read or write data from the socket.

2.  It would be nice to be able to pass a timeout value to get(),
get_url(), etc.  The default timeout seems to be 30 seconds, which can
be a long time to wait for some of us.  :)

Thanks again,

Thomas

Attachment: UPnP-info.patch
Description: UPnP-info.patch

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org