Re: Cmake on windows

[Pascal Quantin <pascal () wireshark org>]

Hi Dario,

Le ven. 6 mars 2020 à 11:30, Dario Lombardo <lomato () gmail com> a écrit :

> No, it's the same. Have a look at the cmake section and you will see the
> error messages below.

Joao is correct: on one side you have a non fatal error in CMake that only
impacts the WiX installer, and in the other side your machine does not have
the MSVC redistributable copied in the wireshark-libs folder (as explained
in the developer guide) while it is required for the NSIS installer.


> On Fri, Mar 6, 2020 at 10:54 AM João Valverde <
> joao.valverde () tecnico ulisboa pt> wrote:
>
> > On 06/03/20 08:23, Dario Lombardo wrote:
> >
> > Example of failing build
> >
> >
> > https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true
> >
> >
> > A quick look suggests this is a different build than you indicated
> > before, for an NSIS package, and the problem seems to be that the VC_REDIST
> > exe is missing.
> >
> >
> > On Fri, Mar 6, 2020 at 9:07 AM Dario Lombardo <lomato () gmail com> wrote:
> >
> > > Are you saying "set v"? It doesn't print anything.
> > > The installation of VS is pre-made by the github builder itself, not by
> > > me, hence I don't have any control over the installation options. However I
> > > guess every component is in place, and maybe I just need to add the proper
> > > dir to the PATH. What do you think?
> > >
> > > On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs <gerald () wireshark org>
> > > wrote:
> > >
> > > > On 3/5/20 7:27 AM, Dario Lombardo wrote:
> > > > > Hi,
> > > > > I'm getting this output from a windows build
> > > > >
> > > > > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
> > > > > -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for
> > > > the WiX installer
> > > > > -- Configuring done
> > > > > -- Generating done
> > > > > -- Build files have been written to: D:/a/wireshark/wireshark/build
> > > > >
> > > > > What's going wrong? The rest of the output looks good.
> > > >
> > > > VCINSTALLDIR should have been set by Visual Studio, e.g. by
> > > > vcvarsall.bat. What does `set v` show?
> > > >
> > > > ___________________________________________________________________________
> > > > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > > > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > > > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> > > >              mailto:wireshark-dev-request () wireshark org
> > > > ?subject=unsubscribe
> > >
> > >
> > >
> > > --
> > >
> > > Naima is online.
> >
> > --
> >
> > Naima is online.
> >
> >
> > ___________________________________________________________________________
> > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org> <wireshark-dev () wireshark org>
> > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe <wireshark-dev-request () wireshark 
> > org?subject=unsubscribe>
> >
> >
> >
> > ___________________________________________________________________________
> > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> > Archives:    https://www.wireshark.org/lists/wireshark-dev
> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> >              mailto:wireshark-dev-request () wireshark org
> > ?subject=unsubscribe
>
>
>
> --
>
> Naima is online.
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org
> ?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe