Re: Question about git style

[Roland Knall <rknall () gmail com>]

You can do both. In all fairness, we do not enforce a particular working
style with Wireshark, but please keep in mind, that other people must
review the stuff. That being said, it usually goes with - it should compile
and work - after commit. So submitting things, where you and up with a
broken mainline will not fly.

And for gerri, gerri let's you start special branches as well, they are
called "topic". Branches exist as well, but usually if you have more than
one patchset, which depend on each other, you give all of them the same
topic.

cheers
Roland

On Mon, Jan 1, 2018 at 11:44 PM, Craig Jackson <cejackson51 () gmail com>
wrote:

> I'm curious whether each submission to gerrit must be a single commit. I'm
> accustomed with other source management systems to making a branch and then
> committing fairly frequently. I would do intermediate commits before I had
> anything complete enough to be added to the mainline code of what I was
> working on.
>
> I'm new to git and gerrit, but it seems like gerrit wants each submission
> to be a single commit.
>
> What is the best style? Should I do a commit, and then amend it as I
> continue to develop?
>
> Craig Jackson
>
> ____________________________________________________________
> _______________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org?subject=
> unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe