Re: Should I add new commits to address review comments?

[Pascal Quantin <pascal.quantin () gmail com>]

Hi Richard,

2017-07-11 18:10 GMT+02:00 Richard Sharpe <realrichardsharpe () gmail com>:

> Hi folks,
>
> Last time I made a change I created a new commit based on review
> comments and then squashed the two commits, but that caused issues.
>
> Is it better to simply submit the new commit or do I need to ensure I
> keep the original change-id in the commit?

Edit your initial commit with 'commit --amend' and push again. It will keep
the same Change-Id and simply create a new patch set in Gerrit.

Pascal.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe