Re: Should I add new commits to address review comments?

[Graham Bloice <graham.bloice () trihedral com>]

On 11 July 2017 at 17:10, Richard Sharpe <realrichardsharpe () gmail com>
wrote:

> Hi folks,
>
> Last time I made a change I created a new commit based on review
> comments and then squashed the two commits, but that caused issues.
>
> Is it better to simply submit the new commit or do I need to ensure I
> keep the original change-id in the commit?
>
> --
> Regards,
> Richard Sharpe
> (何以解憂？唯有杜康。--曹操)

As per the wiki, amend your original commit, keeping the Change-Id:
https://wiki.wireshark.org/Development/SubmittingPatches#Amending_a_Change

-- 
Graham Bloice

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe