Re: Making oui_base_custom available more generally

[Michael Mann via Wireshark-dev <wireshark-dev () wireshark org>]

I don't know exactly how far BASE_CUSTOM goes back, but it is for "custom" display of a field.  But if there are enough 
fields with the same "custom" formatting, it's probably time to make it a field type (or add BASE_ type)
 
 
-----Original Message-----
From: Richard Sharpe <realrichardsharpe () gmail com>
To: Developer support list for Wireshark <wireshark-dev () wireshark org>
Sent: Sat, Aug 19, 2017 10:16 am
Subject: Re: [Wireshark-dev] Making oui_base_custom available more generally

On Sat, Aug 19, 2017 at 5:19 AM, Michael Mann via Wireshark-dev<wireshark-dev () wireshark org> wrote:> If you're 
talking about oui_base_custom(), I think the better idea would be> to create a field type (FT_OUI) for it.This is an 
idea I like. However, how far back does BASE_CUSTOM go?> -----Original Message-----> From: Roland Knall <rknall () 
gmail com>> To: Developer support list for Wireshark <wireshark-dev () wireshark org>> Sent: Sat, Aug 19, 2017 7:16 am> 
Subject: Re: [Wireshark-dev] Making oui_base_custom available more generally>> Which OUI are we talking about? 
Generally speaking, a wsutil/oui_handler.?> could be useful, as for instance, openSAFETY uses OUI-24 as well. So it> 
could be made the case, to move the OUI handling outside of the dissector> and into a generic wsutil or epan 
structure.>> cheers,> Roland>> On Sat, Aug 19, 2017 at 1:04 PM, Dario Lombardo> <dario.lombardo.ml () gmail com> 
wrote:>> I don't think that's enough. The linker should be able to resolve the symbol> this way, but the compiler 
shouldn't. Then you'd have to declare it extern.> But the right thing to do is to create a .h file that holds the 
public> declaration of the .c file, and include it. This is a best practice> generally speaking, and it's whas is done 
in wireshark as well. Have a look> at packet-dns.c/h that do what you think. Moreover, there is already a file> 
packet-ieee80211.h: that should be the place.> Cheers,> Dario.>> On Sat, Aug 19, 2017 at 4:14 AM, Richard Sharpe> 
<realrichardsharpe () gmail com> wrote:>> Hi folks,>> I have a need to deal with OUIs in a dissector I am writing and 
find> that it is defined as static void in packet_ieee80211.c.>> Should I simply remove static from that declaration, 
or should we> promote it to some other file to make it generally available?>> --> Regards,> Richard Sharpe> 
(何以解憂？唯有杜康。--曹操)> ___________________________________________________________________________> Sent via:    
Wireshark-dev mailing list <wireshark-dev () wireshark org>> Archives:    
https://www.wireshark.org/lists/wireshark-dev> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev>    
          mailto:wireshark-dev-request () wireshark org?subject=unsubscribe>>>> 
___________________________________________________________________________> Sent via:    Wireshark-dev mailing list 
<wireshark-dev () wireshark org>> Archives:    https://www.wireshark.org/lists/wireshark-dev> Unsubscribe: 
https://www.wireshark.org/mailman/options/wireshark-dev>              mailto:wireshark-dev-request () wireshark 
org?subject=unsubscribe>>> ___________________________________________________________________________> Sent via: 
Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives:> https://www.wireshark.org/lists/wireshark-dev 
Unsubscribe:> https://www.wireshark.org/mailman/options/wireshark-dev> mailto:wireshark-dev-request () wireshark 
org?subject=unsubscribe>> ___________________________________________________________________________> Sent via:    
Wireshark-dev mailing list <wireshark-dev () wireshark org>> Archives:    
https://www.wireshark.org/lists/wireshark-dev> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev>    
          mailto:wireshark-dev-request () wireshark org?subject=unsubscribe-- Regards,Richard 
Sharpe(何以解憂？唯有杜康。--曹操)___________________________________________________________________________Sent via:    
Wireshark-dev mailing list <wireshark-dev () wireshark org>Archives:    
https://www.wireshark.org/lists/wireshark-devUnsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev       
      mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe