Re: Making oui_base_custom available more generally

[Dario Lombardo <dario.lombardo.ml () gmail com>]

I don't think that's enough. The linker should be able to resolve the
symbol this way, but the compiler shouldn't. Then you'd have to declare it
extern. But the right thing to do is to create a .h file that holds the
public declaration of the .c file, and include it. This is a best practice
generally speaking, and it's whas is done in wireshark as well. Have a look
at packet-dns.c/h that do what you think. Moreover, there is already a file
packet-ieee80211.h: that should be the place.
Cheers,
Dario.

On Sat, Aug 19, 2017 at 4:14 AM, Richard Sharpe <realrichardsharpe () gmail com
> wrote:

> Hi folks,
>
> I have a need to deal with OUIs in a dissector I am writing and find
> that it is defined as static void in packet_ieee80211.c.
>
> Should I simply remove static from that declaration, or should we
> promote it to some other file to make it generally available?
>
> --
> Regards,
> Richard Sharpe
> (何以解憂？唯有杜康。--曹操)
> ____________________________________________________________
> _______________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org?subject=
> unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe