Re: TRANSUM C Port

[Paul Offord <Paul.Offord () advance7 com>]

OK – Thanks Graham.

From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Graham Bloice
Sent: 02 September 2016 09:27
To: Developer support list for Wireshark <wireshark-dev () wireshark org>
Subject: Re: [Wireshark-dev] TRANSUM C Port



On 2 September 2016 at 09:16, Paul Offord <Paul.Offord () advance7 com<mailto:Paul.Offord () advance7 com>> wrote:
Hi,

I’m porting TRANSUM to C.  I’m about 80% through the job.  I want to submit it for consideration to be included in the 
Wireshark distribution.  It’s a custom postdissector and so lives in the plugin directory alongside Gryphon, MATE, etc.


•        Can I submit the code to the Git repository during development or should I wait until I have a working version?

I understand git branches a little and I’ve created local branches and I’ve read the Contribute Your Changes section of 
the Developer’s Guide.

Thanks and regards…Paul


The submission will have to go through the review process at some point, a submission earlier in the process might 
point out issues to save effort on the remaining parts to be completed.  The other aspect of submission for review is 
that it would also allow test builds to be done on both Windows and Ubuntu platforms via the Petri-dish builder.

Note that you should squash any commits in your local branch before submitting the changes to keep a single change in 
Gerrit.  Using git-review helps a lot here, highly recommended.

If you do decide to submit before it's complete, prefix the commit message with "[WIP]" so that it won't accidentally 
be merged, the prefix can be removed from the message when ready.

A bugzilla entry (referenced in the commit message with a Bug: xxxx footer) with attached sample captures will also 
help the review.



--
Graham Bloice

______________________________________________________________________

This message contains confidential information and is intended only for the individual named. If you are not the named 
addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if 
you have received this e-mail by mistake and delete this e-mail from your system.

Any views or opinions expressed are solely those of the author and do not necessarily represent those of Advance Seven 
Ltd. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, 
corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept 
liability for any errors or omissions in the contents of this message, which arise as a result of e-mail transmission.

Advance Seven Ltd. Registered in England & Wales numbered 2373877 at Endeavour House, Coopers End Lane, Stansted, Essex 
CM24 1SJ

______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com
______________________________________________________________________

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe