Re: GUI Change for Wireshark Remote Interfaces

[Joerg Mayer <jmayer () loplof de>]

On Thu, Oct 27, 2016 at 12:09:20PM -0700, Guy Harris wrote:
> On Oct 27, 2016, at 11:28 AM, Roland Knall <rknall () gmail com> wrote:
>
> > Guy, is the version on github for libpcap already equipped with pcap_open on Mac?
>
> The current version on github has pcap_open() in pcap-new.c; *however*:
>
>       1) it's not in Makefile.in, so it doesn't show up if you do autotools builds;
>       
>       2) it's only in CMake builds if HAVE_REMOTE is defined, which is done by default only on Windows;
>
>       3) I have not tested whether it builds and is useful on any UN*X platform - it might not work.

1) SEP ;-)

2) Easy to fix

3) It will neither compile nor link.

The attached patch will make it compile and link - nothing else was tested
mkdir build; cd build; cmake -DHAVE_REMOTE=ON ..; make

Feel free to ignore, modify or apply the patch (the policy 42 stuff fixes
the symptom instead of the root cause).

 Jörg
-- 
Joerg Mayer                                           <jmayer () loplof de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.

Attachment: have_remote_macos.patch
Description:

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe