Re: Duplicate dissectors error

[Guy Harris <guy () alum mit edu>]

On Aug 29, 2016, at 6:09 PM, Michael Mann <mmann78 () netscape net> wrote:

> Yes, that's the main side effect, and if all the registering is with proprietary dissectors, it's your users that 
> have to deal with it.
> Solutions are:
> 1. Change dissector table to allow duplicates.
> 2. Create "placeholder" protocols (you'll see a few examples in native Wireshark dissectors) so that each can show up 
> differently in Decode As.

Or

3. In dissector_add_for_decode_as(), if you find an entry in the list of "for decode as" handles for the same handle it 
was asked to add, just silent ignore the request to add it.

That way, if the same handle is added multiple times - for example, if that handle is used for multiple different keys 
in a dissector table, so that dissector_add_for_decode_as() is called multiple times for that handle and that dissector 
table - there's never any output.

If that means we can get rid of the allow_dup_proto flag, great!
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe