Re: checkapi

[Jeff Morriss <jeff.morriss.ws () gmail com>]

On Mon, Apr 11, 2016 at 10:29 AM, Jeff Morriss <jeff.morriss.ws () gmail com>
wrote:

> On Sun, Apr 10, 2016 at 4:44 PM, Graham Bloice <
> graham.bloice () trihedral com> wrote:
>
> > After creating an initial change to add checkAPI to CMake builds,
> > following the current checks done by nmake, I got the attached (massaged)
> > output.
>
>
> > CUSTOMBUILD : error : Found prohibited APIs in guid-utils.c: _snwprintf
> > [C:\buildbot\builders\windows-x86-petri-dish\windows-x86-petri-dish\build\cmbuild\epan\checkAPI_epan.vcxproj]
>
> Gerald (in r43756) said this should be StringCchPrintf().  Not sure why.

The Windows docs say the latter function is safer; change submitted.


> CUSTOMBUILD : error : Found prohibited APIs in ftype-guid.c: strncpy
> > [C:\buildbot\builders\windows-x86-petri-dish\windows-x86-petri-dish\build\cmbuild\epan\ftypes\checkAPI_ftypes.vcxproj]
> > CUSTOMBUILD : error : Found prohibited APIs in ftype-pcre.c: strcpy
> > [C:\buildbot\builders\windows-x86-petri-dish\windows-x86-petri-dish\build\cmbuild\epan\ftypes\checkAPI_ftypes.vcxproj]
> > CUSTOMBUILD : error : Found prohibited APIs in ftype-string.c: strcpy
> > [C:\buildbot\builders\windows-x86-petri-dish\windows-x86-petri-dish\build\cmbuild\epan\ftypes\checkAPI_ftypes.vcxproj]
> > CUSTOMBUILD : error : Found prohibited APIs in ftype-time.c: strcpy
> > [C:\buildbot\builders\windows-x86-petri-dish\windows-x86-petri-dish\build\cmbuild\epan\ftypes\checkAPI_ftypes.vcxproj]
>
> Looks like these have snuck in while the buildbots weren't running
> checkapi; checkapis run from autotools also complains.

Actually, no, those have "always" been there; neither the nmake nor
autotools checkapi ran in that directory.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe