Wireshark mailing list archives
Re: Make CMake reuse Makefile.common?
From: Alexis La Goutte <alexis.lagoutte () gmail com>
Date: Tue, 3 Mar 2015 17:50:10 +0100
On Mon, Mar 2, 2015 at 1:16 PM, Peter Wu <peter () lekensteyn nl> wrote:
Hi, Recently there have been two issues due to separate copies between CMake and autofoo (missing ATH dissector, missing field registrations for plugins). The former could occur due to missing duplication from Makefile.common into CMakeLists.txt. The latter happens because the plugins/*/CMakeLists.txt are slightly different than the Makefiles (in terms of variable sets). Hereby I am proposing to convert Makefile.common automatically to CMakeLists.inc.txt, and then include that during the build process to set variables. The inspiration comes from cURL which too supports autoconf, and (as an experimental option) cmake. See this transformation macro[0] and its use[1] for an example.
Hi Peter, Need to try... but i known CMake cURL is no perfect... and there is some plan to drop support of CMake ;-) And also if i remember the target is only have CMake for build system (and remove autofoo...)
-- Kind regards, Peter Wu https://lekensteyn.nl [0]: https://github.com/bagder/curl/blob/master/CMakeLists.txt#L986 [1]: https://github.com/bagder/curl/blob/master/tests/libtest/CMakeLists.txt#L31 ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org ?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Make CMake reuse Makefile.common? Peter Wu (Mar 02)
- Re: Make CMake reuse Makefile.common? Alexis La Goutte (Mar 03)
- Re: Make CMake reuse Makefile.common? Jeff Morriss (Mar 03)
- Re: Make CMake reuse Makefile.common? Michal Labedzki (Mar 04)
- Re: Make CMake reuse Makefile.common? Jeff Morriss (Mar 04)
- Re: Make CMake reuse Makefile.common? Graham Bloice (Mar 04)
- Re: Make CMake reuse Makefile.common? Jeff Morriss (Mar 04)
- Re: Make CMake reuse Makefile.common? Graham Bloice (Mar 04)
- Re: Make CMake reuse Makefile.common? Jeff Morriss (Mar 04)
- Re: Make CMake reuse Makefile.common? Graham Bloice (Mar 04)
- Re: Make CMake reuse Makefile.common? Graham Bloice (Mar 04)
- Re: Make CMake reuse Makefile.common? Jeff Morriss (Mar 04)
- Re: Make CMake reuse Makefile.common? Jeff Morriss (Mar 03)
- Re: Make CMake reuse Makefile.common? Alexis La Goutte (Mar 03)