Wireshark mailing list archives
removing mergecap -T option
From: Hadriel Kaplan <the.real.hadriel () gmail com>
Date: Fri, 14 Aug 2015 12:18:08 -0400
Howdy, Due to some reported bugs and inconsistencies, I'm refactoring the capture file merging code in mergecap.c and file.c's cf_merge_files() - basically gutting them and putting most of the logic into a common "merge_files()" function in merge.c. While merging their function code logic, I noticed that mergecap lets the user set the frame encap type to use for the new output file, with a '-T' option. That seems completely useless to me, since you can't really change the encap type of what was in the original capture files; nor does mergecap seem to do so either, nor does it filter/save only those packet encap types, nor verify that the input files had that, nor really anything useful - all it appears it can accomplish is to produce invalid output files. Does anyone mind if I remove the '-T' option from mergecap? -hadriel ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- removing mergecap -T option Hadriel Kaplan (Aug 14)
- Re: removing mergecap -T option Pascal Quantin (Aug 14)
- Re: removing mergecap -T option Hadriel Kaplan (Aug 14)
- Re: removing mergecap -T option Pascal Quantin (Aug 14)
- Re: removing mergecap -T option Hadriel Kaplan (Aug 14)
- Re: removing mergecap -T option Guy Harris (Aug 14)
- Re: removing mergecap -T option Pascal Quantin (Aug 14)