Re: --without-gtk3 doesn't imply --with-qt

[Guy Harris <guy () alum mit edu>]

On Nov 25, 2014, at 7:09 PM, Jeff Morriss <jeff.morriss.ws () gmail com> wrote:

> On 11/25/2014 06:09 PM, Stephen Fisher wrote:
> > I decided to stop building my local Wireshark with GTK3 support by
> > adding --without-gtk3 (or --with-gtk3=no) assuming that this would still
> > imply that I wanted it built with qt (--with-qt or --with-qt=yes), since
> > they both default to yes, but the current logic in configure.ac doesn't
> > account for disabling just one and I get this error:
> >
> > configure: error: Neither Qt nor GTK+ 2.12.0 or later are available, so
> > Wireshark can't be compiled
> >
> > Does anyone see a problem with me changing configure.ac to default to
> > --with-qt when --with-gtk3=no?
>
> Well the default in master should be Qt=yes, Gtk3=yes.

Currently, it isn't - it's Qt=no, Gtk=GTK3.

Any objections to making it Qt=yes, Gtk=GTK3?  I.e., build both Qt and GTK+ 3 versions?

> If you use --without-gtk3 (without other options) does that mean:
>
> 1) use gtk2 instead of gtk3 (failing if gtk2 is not found)
> 2) (or) try to use gtk2 if it's there
> 3) (or) don't use gtk at all?

I'd vote for 3) - meaning, with the change I asked about, Qt=yes, Gtk=no.

> What about if you give --without-gtk2 (without other options)?

I'd vote for "OK, you said don't use GTK+ 2, so I'll happily use GTK+ 3" - meaning, with the change I asked about, 
Qt=yes, Gtk=GTK3.

The rules that make sense to me are:

No --with{out}-gtk{n} options, or just --with-gtk3: Gtk=GTK3

Just --with-gtk2: Gtk=GTK2

--with-gtk2 plus --with-gtk3: configure: error: Both GTK+ 2 and GTK+ 3 were specified; choose one but not both (which 
is what we fail with now)

--without-gtk3 or --without-gtk2 or both: Gtk=no

--without-gtk2 and --with-gtk3: Gtk=GTK3

--without-gtk3 and --with-gtk2: Gtk=GTK2

--without-gtk3 and --with-gtk3, or --without-gtk2 and --with-gtk2: live with what autoconf does, which is "believe the 
last --with{out}-gtk2 or --with{out}-gtk3 argument you were passed"

And none of those options would affect the Qt build - that's controlled solely by --with{out}-qt.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe