Re: 1.12.0rc2 : tshark crash when message is on 3 packets

[Pascal Quantin <pascal.quantin () gmail com>]

2014-06-16 22:44 GMT+02:00 wsgd <wsgd () free fr>:

> Hello,
>
> My protocol (only to test this problem) specifications :
> tcp port 20640
> message is 5 bytes long
>
>
>
> command line : tshark -r pb.cap  -T text -V
> --> crash (see pb.1.12.0.txt)
> **
> ERROR:print.c:838:get_field_data: code should not be reached
>
> This application has requested the Runtime to terminate it in an unusual
> way.
> Please contact the application's support team for more information.
>
>
>
> wireshark does not crash and display is ok
> tshark 1.10.6 does not crash and display is ok (see pb.1.10.6.txt)
>
>
> Plugin dissector code is into packet-tcp-5-bytes.c
>
>
>
> Regards,
> Olivier


Hi Olivier,

thanks for the report.
This is a regression introduced by g21e0a63b2 commit for bug 9169. I
proposed a fix (not calling the data dissector when a subdissector claims
that the current TCP fragment needs more desegmentation) here:
https://code.wireshark.org/review/2350

Regards,
Pascal.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe