Wireshark mailing list archives

Re: Gerrit Drafts


From: Gerald Combs <gerald () wireshark org>
Date: Fri, 13 Jun 2014 11:00:36 -0700

On 6/13/14 6:35 AM, Alexis La Goutte wrote:
On Fri, Jun 13, 2014 at 3:30 PM, Evan Huus <eapache () gmail com> wrote:
Hi Evan,

I was poking around gerrit a bit and I found an alternative way of handling
WIP (work-in-progress) code. Apparently if you push to refs/drafts/BRANCH
instead of refs/for/BRANCH (or alternatively pass -D to git-review) the
review ends up in a special draft state that gerrit handles.
No problem to use refs/drafts/BRANCH but for the moment draft is only
see by author... (i think need to modify the Gerrit Configuration)

Thoughts on using this instead of manual [WIP] tags? Openstack's wiki
suggests not using it because it doesn't play well with their CI (test
servers) but I don't know if that's an issue for us or not.
Will no be a problem for us (it is possible to choose the branch where
there is CI)

OpenStack added a separate "WIP" state to their Gerrit installation:
https://gerrit-review.googlesource.com/#/c/36091/ . It looks like this
was needed due to the sheer volume of reviews that they have to deal
with. I think it would be overkill in our case.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: