Re: pre-commit hook issue

[Martin Mathieson <martin.r.mathieson () googlemail com>]

Ha, I'm having my own problems with commit_msg, but am replying because I
have some almost-ready changes that will need to reinstate packet-ipsec.h.

My changes are to add a function to add an SA from another (private)
dissector, and also to speed up ESP:decryption in several ways.

Martin


On Sun, Apr 27, 2014 at 3:34 AM, <mmann78 () netscape net> wrote:

> I believe I just deleted the file in Windows Explorer, but the "commit
> list" (and their file status) doesn't look any different than if I had used
> the git menu.
>
>
>
> -----Original Message-----
> From: Evan Huus <eapache () gmail com>
> To: Developer support list for Wireshark <wireshark-dev () wireshark org>
> Sent: Sat, Apr 26, 2014 10:24 pm
> Subject: Re: [Wireshark-dev] pre-commit hook issue
>
>
>  On Apr 26, 2014, at 10:18 PM, mmann78 () netscape net wrote:
>
>   I have found myself from time to time needing to temporarily disable
> the pre-commit hook (ie error is ignorable).  The situation I ran into
> today I don't think should have been.
>
> I created a patch that removed a header file from epan\dissectors
> (packet-ipsec.h).  When I tried to commit it, the pre-commit hook errored
> out with "can't find packet-ipsec.h" and failed the commit.  Is there
> something I'm missing (using TortoiseGit) or does the script need to be
> tweaked to ignore deleted files?
>
>
>  The latter I expect. Was the file deleted according to git or just
> according to the file system?
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>
> mailto:wireshark-dev-request () wireshark org?subject=unsubscribe<wireshark-dev-request () wireshark 
> org?subject=unsubscribe>
>
>  ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org?subject=unsubscribe <wireshark-dev-request () wireshark 
> org?subject=unsubscribe>
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org
> ?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe