Re: wmem_strbuf_printf()

[Pascal Quantin <pascal.quantin () gmail com>]

Hi Martin,

on my side while converting some dissectors to wmem, I replaced the
ep_strbuf_printf by:
- either a call to wmem_strbuf_append_printf directly if it was the first
time the buffer was filled
- or a combination of wmem_strbuf_truncate / wmem_strbuf_append_printf

Regards,
Pascal.


2013/9/15 Martin Kaiser <lists () kaiser cx>

> Dear all,
>
> I just looked at the radius dissector and saw the call to
> ep_strbuf_printf(), which has no wmem equivalent.
>
> I guess wmem_strbuf_printf() could be as simple as
>
> void
> wmem_strbuf_printf(wmem_strbuf_t *strbuf, const gchar *format, ...)
> {
>     va_list ap;
>
>     if (!strbuf)
>         return;
>
>     strbuf->len = 0;
>
>     va_start(ap, format);
>     wmem_strbuf_append_vprintf(strbuf, format, ap);
>     va_end(ap);
> }
>
>
> Are you ok with me adding this or has this been left out on purpose?
>
> I'm aware that ui/profile.c has some calls to ep_strbuf_printf(). For
> those, conversion to wmem may not be straightforward.
>
> Best regards,
>
>    Martin
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org
> ?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe