Wireshark mailing list archives
Re: wmem_strbuf_printf()
From: Evan Huus <eapache () gmail com>
Date: Sun, 15 Sep 2013 13:55:59 -0400
I left it out because I figured it was simpler to just call wmem_strbuf_truncate(strbuf, 0) and then wmem_strbuf_append_* rather than having an append and non-append version of each function. Maybe the non-append versions could just be macros calling truncate and then the append version? I have no strong preference here. Evan On Sun, Sep 15, 2013 at 1:45 PM, Martin Kaiser <lists () kaiser cx> wrote:
Dear all, I just looked at the radius dissector and saw the call to ep_strbuf_printf(), which has no wmem equivalent. I guess wmem_strbuf_printf() could be as simple as void wmem_strbuf_printf(wmem_strbuf_t *strbuf, const gchar *format, ...) { va_list ap; if (!strbuf) return; strbuf->len = 0; va_start(ap, format); wmem_strbuf_append_vprintf(strbuf, format, ap); va_end(ap); } Are you ok with me adding this or has this been left out on purpose? I'm aware that ui/profile.c has some calls to ep_strbuf_printf(). For those, conversion to wmem may not be straightforward. Best regards, Martin ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- wmem_strbuf_printf() Martin Kaiser (Sep 15)
- Re: wmem_strbuf_printf() Evan Huus (Sep 15)
- Re: wmem_strbuf_printf() Pascal Quantin (Sep 15)
- Re: wmem_strbuf_printf() Martin Kaiser (Sep 15)