Wireshark mailing list archives

Re: [Wireshark-commits] rev 53167: /trunk/wiretap/ /trunk/wiretap/: k12text.l


From: Guy Harris <guy () alum mit edu>
Date: Fri, 8 Nov 2013 11:30:27 -0800


On Nov 8, 2013, at 3:42 AM, jmayer () wireshark org wrote:

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=53167

User: jmayer
Date: 2013/11/08 11:42 AM

Log:
Looks like r53166 was not compile tested.

I'd used a shell loop

        for i in `egrep -l 'wth->file_type' *.c`
        do
                ed - $i <<EOF
        g/wth->file_type/s//wth->file_type_subtype/g
        w
        q
        EOF
        done

to update the files, but that meant that it updated the *output* of Flex but not the *input*.  That meant that the 
output was newer than the input, so Flex wasn't re-run, so it compiled - but wouldn't have compiled after a "make 
distclean" (or after a "make clean" if that removes Flex output).

I should have used "*.[chyl]" (as I'd done in some other such loops), which would have fixed the input as well.

Sorry about that.

Now k12text.l compiles again.

Thanks.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: