Wireshark mailing list archives

Re: [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/ui/qt/: main_window_slots.cpp

From: Guy Harris <guy () alum mit edu>
Date: Thu, 21 Nov 2013 11:30:35 -0800


On Nov 21, 2013, at 11:28 AM, Jakub Zawadzki <darkjames-ws () darkjames pl> wrote:

I'd rather use proto_get_id_by_filter_name() in some init function, and later compare.

Making variables extern is somehow tempting, like we could extern dissector handles and stop using find_dissector() ;]
But I think it's wrong way.


+1 (as one might infer from my previous message)
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread:

Re: [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/ui/qt/: main_window_slots.cpp Evan Huus (Nov 21)
- Re: [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/ui/qt/: main_window_slots.cpp mmann78 (Nov 21)
  - Re: [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/ui/qt/: main_window_slots.cpp Evan Huus (Nov 21)
    - Re: [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/ui/qt/: main_window_slots.cpp Jakub Zawadzki (Nov 21)
    - Re: [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/ui/qt/: main_window_slots.cpp Guy Harris (Nov 21)
  - Re: [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/ui/qt/: main_window_slots.cpp Guy Harris (Nov 21)