Re: [Wireshark-commits] rev 53473: /trunk/ui/ /trunk/ui/gtk/: main_menubar.c /trunk/ui/qt/: main_window_slots.cpp

[Evan Huus <eapache () gmail com>]

Rather than doing string comparisons you should just be able to compare the value directly to the proto_* variable for 
the relevant protocol. Most of the necessary ones should already be I'm public headers.

> On Nov 21, 2013, at 7:16 AM, mmann () wireshark org wrote:
>
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=53473
>
> User: mmann
> Date: 2013/11/21 12:16 PM
>
> Log:
> Walk list of protocol strings to determine which protocols are present in a packet rather than rely on protocol 
> specific items in packet_info in an effort to (eventually) reduce packet_info members.
>
> Directory: /trunk/ui/gtk/
>  Changes    Path              Action
>  +69 -20    main_menubar.c    Modified
>
> Directory: /trunk/ui/qt/
>  Changes    Path                     Action
>  +40 -16    main_window_slots.cpp    Modified
>
> ___________________________________________________________________________
> Sent via:    Wireshark-commits mailing list <wireshark-commits () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>             mailto:wireshark-commits-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe