Wireshark mailing list archives
Re: Merging wiretap pint macro to wsutil/pint.h
From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Tue, 19 Nov 2013 19:15:54 +0100
On Mon, Nov 18, 2013 at 03:34:44PM -0800, Guy Harris wrote:
I think using the number of bits is cleaner, but going that way everywhere, not just in those macros, *would* be a major change (mechanical, but still a change).
I only want to make wtap-int.h use pint.h macros, htons(), htonl(), htonll() is kinda easier to write and looks prettier for me than hton16, hton32, hton64(). But it's 2 against 1, so I will make suggested change. Thanks for opinion. Cheers, Kuba. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Merging wiretap pint macro to wsutil/pint.h Jakub Zawadzki (Nov 17)
- Re: Merging wiretap pint macro to wsutil/pint.h Michal Labedzki (Nov 17)
- Re: Merging wiretap pint macro to wsutil/pint.h Guy Harris (Nov 18)
- Re: Merging wiretap pint macro to wsutil/pint.h Jakub Zawadzki (Nov 19)
- Re: Merging wiretap pint macro to wsutil/pint.h Jakub Zawadzki (Nov 28)
- Re: Merging wiretap pint macro to wsutil/pint.h Guy Harris (Nov 28)
- Re: Merging wiretap pint macro to wsutil/pint.h Jakub Zawadzki (Nov 28)
- Re: Merging wiretap pint macro to wsutil/pint.h Guy Harris (Nov 28)
- Re: Merging wiretap pint macro to wsutil/pint.h Guy Harris (Nov 18)
- Re: Merging wiretap pint macro to wsutil/pint.h Michal Labedzki (Nov 17)