Wireshark mailing list archives

Merging wiretap pint macro to wsutil/pint.h


From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Sun, 17 Nov 2013 14:29:22 +0100

Hello,

Right now we have the similar set of macros inside wtap-int.h & pint.h.
I'd like to merge wtap-int.h macros to pint.h

The main difference is in naming of 64-bits version.

In pint.h it ends with 64 (pntoh64, pletoh64) in wtap it ends with ll
(pntohll, pletohll, phtonll, phtolell, htolell)

Which one we prefer? To be honest I'm bigger fan of 'll'.

If we want to use '64' I think it'd be also good to rename
s[hort] and l[ong] version to match convention:

  pntohs -> pntoh16
  pntohl -> pntoh32
...
  htoles -> htole16
  htolel -> htole32

Cheers,
Kuba.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


Current thread: