Wireshark mailing list archives

Re: [Wireshark-commits] rev 47059: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c


From: Martin Mathieson <martin.r.mathieson () googlemail com>
Date: Mon, 14 Jan 2013 09:38:21 +0000

On Mon, Jan 14, 2013 at 4:28 AM, <wmeier () wireshark org> wrote:

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=47059

User: wmeier
Date: 2013/01/13 08:28 PM

Log:
 Cleanup: Whitespace, formatting-style, long-lines & etc.
 Use "4 space" indentation.

 Add an XXX comment about better formating needed
  for the text in the Help window (so the
  text columns line up and so the Help text
  looks better).

 Comment out a "does-noting" for loop;

Directory: /trunk/ui/gtk/
  Changes    Path           Action
  +3657 -3643 tcp_graph.c    Modified

___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <
wireshark-commits () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request () wireshark org
?subject=unsubscribe


Hi Bill,
Looking at the diff here
http://anonsvn.wireshark.org/viewvc/trunk/ui/gtk/tcp_graph.c?r1=47059&r2=47058&pathrev=47059,
it looks as though some of your changes have made the indentation worse.

Disclaimer: I don't have a Wireshark dev environment at the moment and
haven't looked at the file properly.

Martin
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: