Re: [Wireshark-commits] rev 47059: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c

[Jeff Morriss <jeff.morriss.ws () gmail com>]

Martin Mathieson wrote:
> On Mon, Jan 14, 2013 at 4:28 AM, <wmeier () wireshark org 
> <mailto:wmeier () wireshark org>> wrote:
>
>     http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=47059
>     <http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=47059>
>
>     User: wmeier
>     Date: 2013/01/13 08:28 PM
>
>     Log:
>      Cleanup: Whitespace, formatting-style, long-lines & etc.
>      Use "4 space" indentation.
[...]
> Hi Bill,
> Looking at the diff 
> here http://anonsvn.wireshark.org/viewvc/trunk/ui/gtk/tcp_graph.c?r1=47059&r2=47058&pathrev=47059 
> <http://anonsvn.wireshark.org/viewvc/trunk/ui/gtk/tcp_graph.c?r1=47059&r2=47058&pathrev=47059>, 
> it looks as though some of your changes have made the indentation worse.
>
> Disclaimer: I don't have a Wireshark dev environment at the moment and 
> haven't looked at the file properly.

That appears to be an artifact of the fact that those diff's are 
(intentionally) not showing white space changes.  I have the same 
problem (indentation looking wrong) when I do "svn diff -x -w" to show 
me my (real) changes.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe