Re: Simpifying exporting DLL symbols

[Pascal Quantin <pascal.quantin () gmail com>]

2013/2/26 Bálint Réczey <balint () balintreczey hu>

> Hi,
>
> I have created the attached patch to control symbol visibility using
> C defines instead of .def and .sym files. It is expected to work on every
> platform and every build system we support, but I did not want to
> commit it without discussing the direction.
>
> I have tested it using autotools and CMake, but I could not give it a try
> on
> Windows or OS X. If you have some time and access to those platform
> please test the patch.
>
> The rationale behind making this change is simplifying the method we
> maintain
> the set of exported symbols and it is also needed by the CMake build.
> AFAIK we can't use the .def and .sym files in CMake.
>
> If we agree to go this way I'll convert libwireshark and libwiretap, too.
> If you have concerns or comments, please share them. :-)
Hi Balint,
I just tried your patch on my Win32 box (MSVC2010) and it seems to be
working fine: symbols exported by libwsutil.dll are the same before and
after the patch.

Regards,
Pascal.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe